feat: add ShutdownWithContext #1383
Conversation
li-jin-gou
force-pushed
the
feat/shutdown_ctx
branch
3 times, most recently
from
2bce7f6
to
1a01bcd
Compare
li-jin-gou
force-pushed
the
feat/shutdown_ctx
branch
from
1a01bcd
to
d4c172d
Compare
| select { | ||
| case <-ctx.Done(): | ||
| err = ctx.Err() | ||
| break END |
There was a problem hiding this comment.
I'm wondering, should this then force close all connections? What does net/http do in this case?
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm wondering, should this then force close all connections? What does
net/httpdo in this case?
The use of Shutdown does not force all connections to close, but rather uses context to control the timeout after all listener have been closed.
|
|
|
Perhaps call the function |
| ln := fasthttputil.NewInmemoryListener() | ||
| s := &Server{ | ||
| Handler: func(ctx *RequestCtx) { | ||
| ctx.Success("aaa/bbb", []byte("real response")) |
There was a problem hiding this comment.
Can you add a time.Sleep(time.Millisecond*100) here and test that ShutdownWithContext returns correctly after the timeout? The test you have now just tests the code that is similar to what TestShutdown already tests. Thanks!
There was a problem hiding this comment.
@erikdubbelboer PTAL
li-jin-gou
force-pushed
the
feat/shutdown_ctx
branch
7 times, most recently
from
536e21c
to
88c5c84
Compare
li-jin-gou
force-pushed
the
feat/shutdown_ctx
branch
from
88c5c84
to
234dd6a
Compare
|
Thanks! |
|
When will it be tagged? |
|
Next week I'll tag a release. |
pr for #1389
ShutdownWithContextfunction to support shutdown with timeout and timeout happen after all listener already close.