Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(server): reset maxRequestBodySize to the server's config #1360

Merged
merged 2 commits into from Aug 23, 2022
Merged

Fix(server): reset maxRequestBodySize to the server's config #1360

merged 2 commits into from Aug 23, 2022

Conversation

GeraltXLi
Copy link
Contributor

Hi, this patch aims to fix issue #1359

erikdubbelboer
erikdubbelboer requested changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@erikdubbelboer erikdubbelboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same with writeTimeout?

@GeraltXLi
Copy link
Contributor Author

Hi, I have reset the writeTimeout

@erikdubbelboer erikdubbelboer merged commit 3b147b7 into valyala:master Aug 23, 2022
@erikdubbelboer
Copy link
Collaborator

Thanks!

bbenzikry pushed a commit to bbenzikry/fasthttp that referenced this pull request Sep 11, 2022
@GeraltXLi @bbenzikry
Fix(server): reset maxRequestBodySize to the server's config (valyala…
0dc05f8 
…#1360)

* fix(server): reset maxRequestBodySize to the server's config when HeaderReceived is set

* fix(server): reset writeTimeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikdubbelboer erikdubbelboer erikdubbelboer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeraltXLi @erikdubbelboer