Optimize server connection close logic #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline isHTTP11 var. Use direct Header.SetConnectionClose() and Header.ConnectionClose()
The SetCanonical(strConnection, strClose) call internally will anyway call SetConnectionClose(). The "Connection: close" will be printed in the ResponseHeader.AppendBytes()
The conn limit check merged into connectionClose evaluation. This improves performance for most cases: 1. If the connectionClose already true then the conn limit check won't be performed. 2. The SetConnectionClose() was duplicated 3. First check conn limit and only then check for resp.connClose because most users don't close conns manually. 4. We may optimize more: If the resp.connClose = true then SetConnectionClose() not needed but as mentioned above this is a rare case.
|
Thanks! |
bbenzikry
pushed a commit
to bbenzikry/fasthttp
that referenced
this pull request
Sep 11, 2022
* server.go Make code more clear Inline isHTTP11 var. Use direct Header.SetConnectionClose() and Header.ConnectionClose() * server.go Use direct SetConnectionClose() The SetCanonical(strConnection, strClose) call internally will anyway call SetConnectionClose(). The "Connection: close" will be printed in the ResponseHeader.AppendBytes() * server.go Simplify connectionClose evaluation The conn limit check merged into connectionClose evaluation. This improves performance for most cases: 1. If the connectionClose already true then the conn limit check won't be performed. 2. The SetConnectionClose() was duplicated 3. First check conn limit and only then check for resp.connClose because most users don't close conns manually. 4. We may optimize more: If the resp.connClose = true then SetConnectionClose() not needed but as mentioned above this is a rare case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR simplifies and slightly improves performance of "Connection: close" header.
Please see commit comments