Add an option to allow empty root in the fsHandler #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment)
this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment)
erikdubbelboer
requested changes
May 13, 2022
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
|
@erikdubbelboer thank you for your suggestions, I have adopted them |
|
Thanks. I'll tag a new release tomorrow. |
bbenzikry
pushed a commit
to bbenzikry/fasthttp
that referenced
this pull request
Sep 11, 2022
* Add an option to allow empty root in the fsHandler this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment) * Add an option to allow empty root in the fsHandler this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment) * Update fs.go Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com> * Update fs.go Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com> Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to allow empty root in the fsHandler
this is necessary to restore the capabilities before the commit c7576cc
and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards
related to:
gofiber/fiber#1882 (comment)