optimize #1275
Merged
optimize #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Apr 22, 2022
args.go
Outdated
| // fast path: src doesn't contain encoded chars | ||
| return append(dst, src...) | ||
| } | ||
|
|
||
| idx := min(idxPercent, idxPlus) | ||
| if idx > 0 { |
There was a problem hiding this comment.
If one of them is -1 you can still start at the other. So I would change this block to be smarter without the min func.
There was a problem hiding this comment.
thx, it would be better
tylitianrui
commented
Apr 24, 2022
erikdubbelboer
requested changes
Apr 24, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize the logic of
fast path. similar pr #1272