Added Windows support and removed some panics #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I seeing the Windows test some times throws timeout in different PRs. Is it possible to run the checks again? BTW: Tested also on my Windows machine. |
|
Looks sane to me. Thanks! |
|
You are welcome and thanks also to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1101 and improve the changes proposed by #1108
List of changes:
rootFS.Rootis now empty andServeFilehas the control to convert a relative path to absolute.filepath.IsAbsto detect if a path is absolute or relative.Extras:
panics and now an error is returned. Crashing an app because the underlying OS calls does not work as expected, is not good. Also the function that may panic, already returns an errors for other situations.