feat: ability to read body separate from header #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Oct 22, 2021
As per @erikdubbelboer suggestion Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
|
Great, I've made the changes. I noticed the 1.15 MacOS test failed - is that a flaky test or did this change inadvertently break something? |
|
It's flaky. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply moves reading the message body into its own function for both the
requestandresponseobject.This is in reference to #1129, and it does not change FastHTTP functionally, simply moves reading the body into its own (exported) function.
This will allow FastHTTP to support streaming protocols for reverse proxying (and potentially in the FastHTTP HostClient as well), by simply adding the ability to read the request/response bodies separate from their headers.