Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless runtime.KeepAlive #1107

Merged
merged 2 commits into from Sep 20, 2021
Merged

Remove useless runtime.KeepAlive #1107

merged 2 commits into from Sep 20, 2021

Conversation

cristaloleg
Copy link
Contributor

According to golang/go#47562 and comment from PR with the removed change (#1079 (comment)) this KeepAlive is meaningless.

@erikdubbelboer erikdubbelboer merged commit adc0e57 into valyala:master Sep 20, 2021
@erikdubbelboer
Copy link
Collaborator

Thanks!

@cristaloleg cristaloleg deleted the patch-1 branch September 20, 2021 14:45
@erikdubbelboer erikdubbelboer mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@un000 un000 un000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cristaloleg @erikdubbelboer @un000