Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isUUID) - Add support for validation of version v1 and v2 #1848

Merged
merged 3 commits into from Oct 31, 2021

Conversation

theteladras
Copy link
Contributor

Added validation support for UUID version 1 and version 2. Also a minor fix was made for returning undefined instead of returning a boolean.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #1848 (4205621) into master (5773869) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1848   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2052      2052           
  Branches       463       463           
=========================================
  Hits          2052      2052           
Impacted Files Coverage Δ
src/lib/isUUID.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5773869...4205621. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for your PR !

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit af2b43c into validatorjs:master Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* fix(isUUID) for null version argument supply

* improve(isUUID) validation for version 1 and 2
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* fix(isUUID) for null version argument supply

* improve(isUUID) validation for version 1 and 2
lpicchi added a commit to lpicchi/DefinitelyTyped that referenced this pull request May 4, 2023
New UUID versions 1 and 2 are now supported since 13.0.7
(validatorjs/validator.js#1848)
thefat32 pushed a commit to thefat32/DefinitelyTyped that referenced this pull request May 5, 2023
New UUID versions 1 and 2 are now supported since 13.0.7
(validatorjs/validator.js#1848)
thefat32 added a commit to thefat32/DefinitelyTyped that referenced this pull request May 5, 2023
New UUID versions 1 and 2 are now supported since 13.0.7
(validatorjs/validator.js#1848)
peterblazejewicz pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request May 6, 2023
Desplandis pushed a commit to Desplandis/DefinitelyTyped that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants