check more special characters when validating a FQDN #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1799 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
|
This should also close the issue #1087 |
|
Ei @tux-tn Can I have your feedback about this? 😇 |
|
@MatteoPierro Yes sir! i'm reviewing some pending PRs, i will probably check yours today! Thank you |
tux-tn
approved these changes
Oct 19, 2021
|
May I ask if you can add the label |
Done 😃 |
theteladras
pushed a commit
to theteladras/validator.js
that referenced
this pull request
Oct 30, 2021
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to detect a FQDN as invalid when containing characters of one of these UTF-8 blocks:
Checklist