Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: run scripts in parallel for build and clean #1747

Merged
merged 2 commits into from Oct 2, 2021
Merged

refactor: run scripts in parallel for build and clean #1747

merged 2 commits into from Oct 2, 2021

Conversation

sachinraja
Copy link
Contributor

@sachinraja sachinraja commented Oct 2, 2021

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1747   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2015      2015           
  Branches       454       454           
=========================================
  Hits          2015      2015           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

@@ -58,17 +59,17 @@
"clean:node": "rimraf index.js lib",
"clean:es": "rimraf es",
"clean:browser": "rimraf validator*.js",
"clean": "npm run clean:node && npm run clean:browser && npm run clean:es",
"clean": "run-p clean:*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change
"clean": "run-p clean:*",
"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

Copy link
Contributor Author

@sachinraja sachinraja Oct 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work on Windows (with cmd.exe)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, shitty cmd🙃

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 ! Thank you for the PR @sachinraja

@tux-tn tux-tn added 🎉 first-pr maintenance ready-to-land For PRs that are reviewed and ready to be landed labels Oct 2, 2021
@sachinraja
Copy link
Contributor Author

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

@tux-tn
Copy link
Member

tux-tn commented Oct 2, 2021

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

@profnandaa
Copy link
Member

Thanks @sachinraja for your PR! 🎉

@profnandaa profnandaa merged commit 05e382b into validatorjs:master Oct 2, 2021
@sachinraja sachinraja deleted the run-parallel branch October 2, 2021 20:13
@sachinraja
Copy link
Contributor Author

Got it, thanks for explaining @tux-tn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr maintenance ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants