From 827b423047e308a700a53d1260d84a99c4e9392a Mon Sep 17 00:00:00 2001 From: drorh Date: Wed, 5 May 2021 16:13:35 +0300 Subject: [PATCH 1/5] feat(niceToHave): Export list of country codes that implement IBAN --- src/index.js | 3 ++- src/lib/isIBAN.js | 2 ++ test/exports.js | 6 ++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 675947481..427714c83 100644 --- a/src/index.js +++ b/src/index.js @@ -48,7 +48,7 @@ import isHSL from './lib/isHSL'; import isISRC from './lib/isISRC'; -import isIBAN from './lib/isIBAN'; +import isIBAN, { locales as ibanCountryCodes } from './lib/isIBAN'; import isBIC from './lib/isBIC'; import isMD5 from './lib/isMD5'; @@ -222,6 +222,7 @@ const validator = { isDate, isLicensePlate, isVAT, + ibanCountryCodes, }; export default validator; diff --git a/src/lib/isIBAN.js b/src/lib/isIBAN.js index 19853aaf2..535a95772 100644 --- a/src/lib/isIBAN.js +++ b/src/lib/isIBAN.js @@ -135,3 +135,5 @@ export default function isIBAN(str) { return hasValidIbanFormat(str) && hasValidIbanChecksum(str); } + +export const locales = Object.keys(ibanRegexThroughCountryCode); diff --git a/test/exports.js b/test/exports.js index 32daa9971..0695a54cc 100644 --- a/test/exports.js +++ b/test/exports.js @@ -5,6 +5,7 @@ import { locales as isAlphaLocales } from '../src/lib/isAlpha'; import { locales as isAlphanumericLocales } from '../src/lib/isAlphanumeric'; import { locales as isMobilePhoneLocales } from '../src/lib/isMobilePhone'; import { locales as isFloatLocales } from '../src/lib/isFloat'; +import { locales as ibanCountryCodes } from '../src/lib/isIBAN'; describe('Exports', () => { it('should export validators', () => { @@ -50,4 +51,9 @@ describe('Exports', () => { assert.ok(isFloatLocales instanceof Array); assert.ok(validator.isFloatLocales instanceof Array); }); + + it('should export a list of country codes that implement IBAN', () => { + assert.ok(ibanCountryCodes instanceof Array); + assert.ok(validator.ibanCountryCodes instanceof Array); + }); }); From 590cf790e5d6f743d8aa1de266aa55ddc7acb078 Mon Sep 17 00:00:00 2001 From: dror-heller Date: Wed, 5 May 2021 19:59:16 +0300 Subject: [PATCH 2/5] Update src/index.js Co-authored-by: Federico Ciardi --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 427714c83..c0dad55f9 100644 --- a/src/index.js +++ b/src/index.js @@ -48,7 +48,7 @@ import isHSL from './lib/isHSL'; import isISRC from './lib/isISRC'; -import isIBAN, { locales as ibanCountryCodes } from './lib/isIBAN'; +import isIBAN, { locales as isIBANLocales } from './lib/isIBAN'; import isBIC from './lib/isBIC'; import isMD5 from './lib/isMD5'; From d950276651e32f47c19679dd3d90905881501bdf Mon Sep 17 00:00:00 2001 From: drorh Date: Thu, 13 May 2021 12:13:48 +0300 Subject: [PATCH 3/5] fix(bug): Export isIBANLocales by its correct alias --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index c0dad55f9..bda29ca83 100644 --- a/src/index.js +++ b/src/index.js @@ -222,7 +222,7 @@ const validator = { isDate, isLicensePlate, isVAT, - ibanCountryCodes, + isIBANLocales, }; export default validator; From 7123c9407ca6ed78bc971270faaf78a353f880ec Mon Sep 17 00:00:00 2001 From: drorh Date: Tue, 25 May 2021 09:52:54 +0300 Subject: [PATCH 4/5] fix(test): fix name change in test --- test/exports.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/exports.js b/test/exports.js index 0695a54cc..e7f3b2679 100644 --- a/test/exports.js +++ b/test/exports.js @@ -54,6 +54,6 @@ describe('Exports', () => { it('should export a list of country codes that implement IBAN', () => { assert.ok(ibanCountryCodes instanceof Array); - assert.ok(validator.ibanCountryCodes instanceof Array); + assert.ok(validator.isIBANLocales instanceof Array); }); }); From 60063078a6e4c16d5fbea7c1f28a12647801030b Mon Sep 17 00:00:00 2001 From: drorh Date: Sun, 11 Jul 2021 10:03:05 +0300 Subject: [PATCH 5/5] fix(standards): change members exported name --- src/index.js | 4 ++-- test/exports.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/index.js b/src/index.js index bda29ca83..59b813c1f 100644 --- a/src/index.js +++ b/src/index.js @@ -48,7 +48,7 @@ import isHSL from './lib/isHSL'; import isISRC from './lib/isISRC'; -import isIBAN, { locales as isIBANLocales } from './lib/isIBAN'; +import isIBAN, { locales as ibanLocales } from './lib/isIBAN'; import isBIC from './lib/isBIC'; import isMD5 from './lib/isMD5'; @@ -222,7 +222,7 @@ const validator = { isDate, isLicensePlate, isVAT, - isIBANLocales, + ibanLocales, }; export default validator; diff --git a/test/exports.js b/test/exports.js index e7f3b2679..0bff532ab 100644 --- a/test/exports.js +++ b/test/exports.js @@ -54,6 +54,6 @@ describe('Exports', () => { it('should export a list of country codes that implement IBAN', () => { assert.ok(ibanCountryCodes instanceof Array); - assert.ok(validator.isIBANLocales instanceof Array); + assert.ok(validator.ibanLocales instanceof Array); }); });