Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate non-ESM support #2238

Open
benasher44 opened this issue Jun 21, 2023 · 2 comments
Open

feat: deprecate non-ESM support #2238

benasher44 opened this issue Jun 21, 2023 · 2 comments

Comments

@benasher44
Copy link

benasher44 commented Jun 21, 2023

Supporting named imports from this package (at least the root "validator" package) is very difficult due to the number of different module systems supported. I opened a PR briefly to attempt this, but it failed for AMD (and maybe others? unless I misunderstood). It can be supported for validator/es, but IDEs don't default to this, nor is there an index.d.ts in @types/validator to support this (i.e. more work is required).

With node 14 EOL having happened this year, node 16 EOL happening later this year, and most browsers supporting ESM, it feels like a good time to migrate to ESM-only via a validator 14

@benasher44
Copy link
Author

Erg sorry I think I chose the wrong template, and it auto-applied the bug label 🤦

@WikiRik
Copy link
Member

WikiRik commented Jun 21, 2023

This relates to the initial attempt at updating our build tooling as well, and comments/references mentioned in there; #1869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants