Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isURL is not working as in the version 13.6.0 #1875

Closed
jagadeesh93 opened this issue Nov 24, 2021 · 5 comments
Closed

isURL is not working as in the version 13.6.0 #1875

jagadeesh93 opened this issue Nov 24, 2021 · 5 comments

Comments

@jagadeesh93
Copy link

jagadeesh93 commented Nov 24, 2021

Description
isURL is not validating some urls which is actually validating in the version 13.6.0

Examples
https://www.facebook.com/pages/ABC Bank/455454545454545/
This URL was giving true in version 13.6.0 but in the latest one it is giving false

@WikiRik
Copy link
Member

WikiRik commented Nov 24, 2021

Probably not a bug, as per #1862 and #1866. Introduced in #1751
Please check RFC 2396 to see if it should be a valid URL or not.

@jagadeesh93
Copy link
Author

@WikiRik Thank you sir , But I have a bunch of facebook urls which has similar of these structure , So how can we ensure a backward compatibility

@WikiRik
Copy link
Member

WikiRik commented Nov 25, 2021

Ah, I read your message wrong. It was true before but false now. The other issues have been the way around. Then this might be a separate issue.
Have you tried https://www.facebook.com/pages/ABC%20Bank/455454545454545/ in 13.7.0?

@pano9000
Copy link
Contributor

  • https://www.facebook.com/pages/ABC Bank/455454545454545/ returns false (which IMHO is correct, as spaces need to be URL encoded)
  • https://www.facebook.com/pages/ABC%20Bank/455454545454545/ returns true (as the space is now correctly URL encoded)

@jagadeesh93 could you check again here please, if that is OK for you as well, as I otherwise would tend to close this issue.

@pano9000
Copy link
Contributor

thanks for reporting, but as I haven't received any feedback, I'll close the issue here.

@pano9000 pano9000 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants