Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add currency codes validator #1703

Closed
jmpaya opened this issue Jul 26, 2021 · 4 comments
Closed

Add currency codes validator #1703

jmpaya opened this issue Jul 26, 2021 · 4 comments
Labels
🙋‍♂️feature-request pr-raised

Comments

@jmpaya
Copy link
Contributor

jmpaya commented Jul 26, 2021

Hi there! Would you mind implement a validator for currency codes as described in ISO 4217?

Thanks,
@tux-tn
Copy link
Member

tux-tn commented Aug 10, 2021

Thank you for your suggestion @jpaya17
PRs are welcome!

jmpaya added a commit to jmpaya/validator.js that referenced this issue Aug 12, 2021
@jmpaya
feat(isISO4217): add currency code validator (validatorjs#1703)
e5fae2e
@jmpaya
Copy link
Contributor Author

jmpaya commented Aug 12, 2021

Thanks @tux-tn for your reply. I have implemented it and created a PR, hope it helps somebody else.

@tux-tn
Copy link
Member

tux-tn commented Aug 20, 2021

Thank you @jpaya17 i will take a look at it 👍

profnandaa pushed a commit that referenced this issue Sep 26, 2021
@jmpaya
feat(isISO4217): add currency code validator (#1706)
f34112d 
* feat(isISO4217): add currency code validator (#1703)

* perf(isISO4217): use a Set along with .has instead of .indexOf

* refactor(isISO4217): Enhance tests with lowercase examples
@tux-tn
Copy link
Member

tux-tn commented Nov 2, 2021

Closed in #1706

@tux-tn tux-tn closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋‍♂️feature-request pr-raised
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tux-tn @jmpaya @ezkemboi