Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload component - remove selected file by triggering X button, close its parent ContextMenu (or any other balloon) #7212

Closed
guygoldwasser opened this issue Mar 14, 2024 · 5 comments
Labels
waiting for author Further information is requested

Comments

@guygoldwasser
Copy link

Description

like described here: #6986
same issue persist with the file upload component.
After select a file, file/s can be removed. The click to remove, is also closing the parent balloon/ContextMenu

Expected outcome

No closing of ancestor popup

Minimal reproducible example

Button popupButton = Button("pop");
VerticalLayout layout = new VerticalLayout();
....
//create some buffer
....
layout.add(new com.vaadin.flow.component.upload.Upload(buffer));
ContextMenu popup = new ContextMenu(popupButton);
popup.add(layout);
popup.setOpenOnClick(true);

Steps to reproduce

  1. create some float popup that close when click outside it
  2. push inside Upload component
  3. open popup and upload a file
  4. remove the file

Environment

Vaadin version(s): 24.5.3
OS: Windows 11

Browsers

Chrome

@yuriy-fix
Copy link
Contributor

Dear @guygoldwasser, would something like dialog with API for positioning suit this use-case or you prefer to use context-menu, and if so could you please describe the motivation behind it?

@yuriy-fix yuriy-fix added the waiting for author Further information is requested label Mar 14, 2024
@guygoldwasser
Copy link
Author

We user slider panel that consist upload. click is closing the slider.

@yuriy-fix
Copy link
Contributor

Dear @guygoldwasser, could you please elaborate a bit more on the details about usage of slider panel and upload? Could you also please provide a screenshot?

@yuriy-fix
Copy link
Contributor

Closing as stale. Feel free to re-open if still valid.

@guygoldwasser
Copy link
Author

i am not sure what difference is make if it slider or some whatever popup that contains the upload component.
same like we had with date when select on calendar close the below popup.

UX experts do the design, and decided that upload component will be in slider which is technically equivalent to popup.
it same same like #6986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants