You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current version of the statistics checker has been implemented around 2018 and it has some issues.
In particular, the fact that this code relies on executing JS from the comment using eval() is just weird.
Now when we support modern browsers with import.meta we could consider re-implementing it.
Describe the solution you'd like
Create a new @vaadin/usage-statistics package in the web components monorepo for 24.1,
Re-implement the actual logic using import.meta if possible, e.g. using Vite as an inspiration,
Make sure only stats are collected and sent as described, and everything works as expected,
Consider also adding UsageStatisticsMixin instead of the ElementMixin for transparency.
The text was updated successfully, but these errors were encountered:
Note, the usage statistics package is included in @vaadin/bundles which is built with Webpack. Webpack doesn't fully support import.meta by default, see webpack/webpack#15833. If somebody uses this package in an app based on Webpack, it won't work. It can probably be worked around by setting up DefinePlugin but that requires manual configuration.
Describe your motivation
The current version of the statistics checker has been implemented around 2018 and it has some issues.
In particular, the fact that this code relies on executing JS from the comment using
eval()
is just weird.Now when we support modern browsers with
import.meta
we could consider re-implementing it.Describe the solution you'd like
@vaadin/usage-statistics
package in the web components monorepo for 24.1,import.meta
if possible, e.g. using Vite as an inspiration,UsageStatisticsMixin
instead of theElementMixin
for transparency.The text was updated successfully, but these errors were encountered: