Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit dependency to xml-apis. Fixes #93 #94

Merged
merged 2 commits into from
Mar 14, 2017
Merged

Add explicit dependency to xml-apis. Fixes #93 #94

merged 2 commits into from
Mar 14, 2017

Conversation

Wnt
Copy link
Contributor

@Wnt Wnt commented Mar 1, 2017 •
edited by Artur-

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@hesara
Copy link
Contributor

hesara commented Mar 9, 2017

Please rebase and/or activate the option that allows project maintainers to update the branch.

@Wnt
Copy link
Contributor Author

Wnt commented Mar 14, 2017 •
edited

Rebased. Where can I find the option to allow project maintainers to update the branch? I could only find option to invite single users by their GitHub username.
Ah, nevermind! It's here in the PR sidebar...

@hesara
Copy link
Contributor

hesara commented Mar 14, 2017

:lgtm: - I'm assuming this does not cause any problematic classpath conflicts, but at least the logs I've seen seem ok.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@hesara hesara merged commit 510aff8 into vaadin:master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wnt @CLAassistant @hesara