Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerelease profile and update release profile #92

Merged
merged 2 commits into from
Feb 28, 2017

Conversation

hesara
Copy link
Contributor

@hesara hesara commented Feb 28, 2017

This change is Reviewable

@elmot
Copy link

elmot commented Feb 28, 2017

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


pom.xml, line 587 at r1 (raw file):

                <rules>
                  <requireMavenVersion>
                    <version>(,2.1.0),(2.1.0,2.2.0),(2.2.0,)</version>

Do we really support Maven 2? Isn't it better to support maven starting from from 3.3 or something?


pom.xml, line 667 at r1 (raw file):

                <rules>
                  <requireMavenVersion>
                    <version>(,2.1.0),(2.1.0,2.2.0),(2.2.0,)</version>

See above about mvn version


Comments from Reviewable

@hesara
Copy link
Contributor Author

hesara commented Feb 28, 2017

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


pom.xml, line 587 at r1 (raw file):

Previously, elmot (Ilia Motornyi) wrote…

Do we really support Maven 2? Isn't it better to support maven starting from from 3.3 or something?

This only excludes the buggy Maven versions, and is identical to how we do it in the parent POM. Until a few weeks ago, the plug-in was still compilable with Maven 2, but as that is no longer the case, I'll simplify the configuration in the Maven plug-in POM. The parent POM (not used by the plug-in) will still have this as it also applies to many other projects, some of which are Maven 2 compatible.


pom.xml, line 667 at r1 (raw file):

Previously, elmot (Ilia Motornyi) wrote…

See above about mvn version

see above


Comments from Reviewable

@elmot
Copy link

elmot commented Feb 28, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@hesara hesara merged commit 549fae6 into master Feb 28, 2017
@hesara hesara deleted the add-prerelease-profile branch February 28, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants