Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vaadin:upgrade8 which runs the migration tool #90

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Add vaadin:upgrade8 which runs the migration tool #90

merged 2 commits into from
Feb 17, 2017

Conversation

ahie
Copy link
Contributor

@ahie ahie commented Feb 17, 2017

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2017

CLA assistant check
All committers have signed the CLA.

@hesara
Copy link
Contributor

hesara commented Feb 17, 2017

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


pom.xml, line 401 at r1 (raw file):

    </dependency>
    <dependency>
      <groupId>com.vaadin</groupId>

(there is a chance that the aether dependencies of the migration tool conflict with those of the Maven plug-in at some point - not sure if we can do much about it now, but we might need to prepare to not have it as a plug-in dependency but download the JAR with aether and run it in a separately forked VM in some future version of the plug-in)


Comments from Reviewable

@ahie ahie merged commit dcba894 into master Feb 17, 2017
@ahie ahie deleted the migration branch February 17, 2017 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants