Add support for "ww" in date format (#12037)

[Ansku]

Calculate number of the week in the year based on Date. Note, support for "ww" is missing from GWT DateTimeFormat and java.util.Calendar is not supported in GWT, hence DIY method is needed.

Fixes: #10603

---

This change is 

[edler-san]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ansku)

---

client/src/main/java/com/vaadin/client/DateTimeService.java, line 45 at r1 (raw file):

Quoted 4 lines of code…

    private int[] yearDays = { 0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 
 304, 334 };
    private int[] leapYearDays = { 0, 31, 60, 91, 121, 152, 182, 213, 244, 274,  
305, 335};

Maybe just do a sum in countWeek?
Line break seem arbitrary.

---

client/src/main/java/com/vaadin/client/DateTimeService.java, line 416 at r1 (raw file):

Quoted 4 lines of code…

        boolean leap = false;
        if (((year % 4) == 0) && (((year % 100) != 0) || ((year % 400) == 0))) {
           leap = true;
        }

No need for the extra if.

boolean leap = ((year % 4) == 0) && (((year % 100) != 0) || ((year % 400) == 0)));

---

client/src/main/java/com/vaadin/client/DateTimeService.java, line 421 at r1 (raw file):

        int week;
        if (leap) {
            week = countWeek(leapYearDays, month, day, weekDay);

Maybe add being a leap year as a parameter?
I.e., week = countWeek(leapYearDays, month, day, weekDay, leap);

[Ansku]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @edler-san)

---

client/src/main/java/com/vaadin/client/DateTimeService.java, line 45 at r1 (raw file):

Previously, edler-san wrote…

    private int[] yearDays = { 0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 
 304, 334 };
    private int[] leapYearDays = { 0, 31, 60, 91, 121, 152, 182, 213, 244, 274,  
305, 335};

Maybe just do a sum in countWeek?
Line break seem arbitrary.

It matches the older maxDaysInMonth handling.
Page width is fixed in the project formatting rules.

---

client/src/main/java/com/vaadin/client/DateTimeService.java, line 416 at r1 (raw file):

Previously, edler-san wrote…

        boolean leap = false;
        if (((year % 4) == 0) && (((year % 100) != 0) || ((year % 400) == 0))) {
           leap = true;
        }

No need for the extra if.

boolean leap = ((year % 4) == 0) && (((year % 100) != 0) || ((year % 400) == 0)));

That would require a new pull request to the main branch, can't be done in a cherry-pick PR.

---

client/src/main/java/com/vaadin/client/DateTimeService.java, line 421 at r1 (raw file):

Previously, edler-san wrote…

Maybe add being a leap year as a parameter?
I.e., week = countWeek(leapYearDays, month, day, weekDay, leap);

Likewise for this one. (You'd also need to drop the first parameter.)