Ensure type safety and serializable nature of all the listeners #12045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansku
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Reviewed 33 of 36 files at r1, 3 of 4 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventRouter did not require the listeners to be rooted to SerializableEventListener and used just Object. This had lead to situation where some listeners were not descentants of SerializableEventListener, but other types. This inturn had lead to situation that some internally used lambdas were not rooted to SerializableEventListener but Object, potentially allowing non-serializable session. This patch fixes the problem. By ensuring the type safety, this should not be no longer possible when new listeners are being added to the framework. Note, many of the existing listeners were correctly extending SerializableEventListener, but not all of them.
This change is