Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin-gradle-plugin does not support Gradle Toolchains #19338

Open
mr-serjey opened this issue May 8, 2024 · 2 comments
Open

Vaadin-gradle-plugin does not support Gradle Toolchains #19338

mr-serjey opened this issue May 8, 2024 · 2 comments

Comments

@mr-serjey
Copy link

mr-serjey commented May 8, 2024

Description of the bug

UI project utilizing vaadin-gradle-plugin fails to build on vaadinBuildFrontend task, when Gradle toolchains configured to higher version of java. e.g JAVA_HOME is java 11, toolchain version is java 17.

Failure happens since gradle compiles java using java 17, but vaadin-gradle-plugin uses java 11 to process classes.

Expected behavior

vaadin-gradle-plugin must respect gradle java toolchain configured in project and use appropriate tools for underlying steps of the build.

Minimal reproducible example

Add toolchain configuration DSL into build.gradle of UI project utilizing vaadin-gradle-plugin e.g.

java {
    toolchain {
        languageVersion = JavaLanguageVersion.of(17)
    }
}

CLI actions:

export JAVA_HOME=<jdk11>
./gradlew build -s
BUILD FAILED
...
vaadinBuildFrontend failed with exception...

Versions

  • Vaadin / Flow version: 23.+, 24.+
  • Java version: 11+
  • OS version: any
  • Browser version (if applicable): n/a
  • Application Server (if applicable): n/a
  • IDE (if applicable): n/a
@mshabarov
Copy link
Contributor

mshabarov commented May 14, 2024

We are not currently sure if the fact that Vaadin Gradle plugin doesn't respect it / support it is a bug or feature.
Let us investigate more about Gradle Toolchain and how common it is for Gradle projects.

@mvysny do you have an idea/suggestion how to treat this issue?

@mvysny
Copy link
Member

mvysny commented May 14, 2024

I do not know much about toolchains, but from what I read at https://docs.gradle.org/current/userguide/toolchains.html , it's a way to compile your project using a different JVM than the one running Gradle itself. In such case vaadin-gradle-plugin should then honor toolchain setting. However, that means that the class processing code (which means Flow plugin code) must run on the toolchain java rather than Gradle java, and I have no idea how that works. Needs investigating how this could be achieved, hopefully using support from Gradle itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 Needs triage
Development

No branches or pull requests

3 participants