fix: change type of Menu order to double #19332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing `Menu#order` type double and `MenuData#order` type to Double to match it with Hilla's `ViewConfig` type `number`. Fixes: #19320
|
tltv
added a commit
to vaadin/hilla
that referenced
this pull request
May 8, 2024
Changing ClientViewMenuConfig order field type from Long to Double to match with Flow's RouteData and Menu annotation. Related-to: vaadin/flow/issues/19332
|
Merging this will break Hilla's |
mcollovati
approved these changes
May 9, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 13, 2024
Changing `Menu#order` type double and `MenuData#order` type to Double to match it with Hilla's `ViewConfig` type `number`. Fixes: #19320
mshabarov
pushed a commit
that referenced
this pull request
May 13, 2024
taefi
pushed a commit
to vaadin/hilla
that referenced
this pull request
May 13, 2024
Changing ClientViewMenuConfig order field type from Long to Double to match with Flow's RouteData and Menu annotation. Related-to: vaadin/flow/issues/19332 Co-authored-by: Anton Platonov <platosha@gmail.com>
vaadin-bot
pushed a commit
to vaadin/hilla
that referenced
this pull request
May 13, 2024
Changing ClientViewMenuConfig order field type from Long to Double to match with Flow's RouteData and Menu annotation. Related-to: vaadin/flow/issues/19332 Co-authored-by: Anton Platonov <platosha@gmail.com>
platosha
added a commit
to vaadin/hilla
that referenced
this pull request
May 14, 2024
chore: change ClientViewMenuConfig order type (#2401) Changing ClientViewMenuConfig order field type from Long to Double to match with Flow's RouteData and Menu annotation. Related-to: vaadin/flow/issues/19332 Co-authored-by: Tomi Virtanen <tltv@vaadin.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
Menu#ordertype double andMenuData#ordertype to Double to match it with Hilla'sViewConfigtypenumber.Fixes: #19320