TCP Keep Alive Control for v4 #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggestion from: #1395 (comment)
Suggestion from: #1395 (comment)
|
It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
@xiaokangwang, could you please review this and comment? Or is it too late for v4? |
It is too late, but I will make an exception for here. I will add reviewing and merging to to do list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backported patch set of #1395 for v2fly v4, with additional patch which properly separates TcpKeepAliveIdle and TcpKeepAliveInterval check logic.