Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneMKL][RNG] Issues with device API #526

Open
andreyfe1 opened this issue Mar 28, 2024 · 0 comments
Open

[oneMKL][RNG] Issues with device API #526

andreyfe1 opened this issue Mar 28, 2024 · 0 comments
Labels
bug Something isn't working MKL

Comments

@andreyfe1
Copy link
Contributor

andreyfe1 commented Mar 28, 2024 •
edited

It doesn't make sense to keep constructors with std::initializer_list for mcg31m1 and mcg59 random generators since one seed value is enough. Size of the state for mcg31m1 is 31 bits, uint32_t is enough to store the initial state. For mcg59 size is 59 bits, uint64_t is enough. So, I'd keep only std::uint32_t seed for mcg31m1 and std::uint64_t seed for mcg59.

PR with bug fixes is here: #525.

Feel free to provide your feedback.
@spencerpatty spencerpatty added bug Something isn't working MKL labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working MKL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreyfe1 @spencerpatty