New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: install WebdriverIO packages as optional dev dependencies #510
Conversation
We must stay with jest@25.5.4 as long as we want to execute our test in node@8 (i.e. until node@14 enters LTS).
d273ac3
to
2bb5684
Compare
2bb5684
to
d82e954
Compare
WebdriverIO which we use for browser testing cannot be installed on some platforms like z/OS. In order to allow "Canary in the Goldmine" (https://github.com/nodejs/citgm) to be run on such platforms as well we need to install WebdriverIO as an optional devDependency. Unfortunately npm doesn't support this out-of-the-box, so we have to wrap the affected dependencies in a small local wrapper package. Fixes #509.
d82e954
to
ec68588
Compare
@IgorTodorovskiIBM could you check if this branch now lets you run the Something like:
(or clone the repo & checkout the |
I just tested it on z/OS and your wrapper solution works perfectly. Thank you so much! |
Cool! @broofa are you fine with this? |
Hmm... would https://github.com/bcoe/optional-dev-dependency offer a slightly less-complicated solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since this works and I don't want to block this, but with the caveat that bcoe's module might avoid the need for a whole new subproject folder.
Oh, that looks promising. For whatever reason me googling for “optional npm dev dependencies” didn’t find it. I will give it a try! |
@IgorTodorovskiIBM based on @broofa's feedback I've now chosen a more elegant approach. Would you mind verifying that CITGM still passes on z/OS once again before we merge this? |
Very cool! CITGM still passes! Thanks! |
Thank you for your help in testing this, @IgorTodorovskiIBM! |
No description provided.