New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add benchmark #430
test: add benchmark #430
Conversation
It does not yet have browser support but I believe that if at all, I have no proof, but I would assume that such high-frequency use cases for |
@ctavan I think performance testing in the browser should also occur locally. If we delegate this task to a third-party service, then distortions in the results may occur. Since we cannot know what tasks are performed in parallel on third-party machines… |
Add a simple benchmark to be able to catch order-of-magnitude performance regressions.
Agree @awwit. I think if at all, this benchmark will only allow us to compare before/after of a certain change on the same machine. I don't think we can get comparable results over time and I also don't intend to do this. |
FWIW, here's the results for node 12.10.0 on my laptop (same laptop I used for the other results I posted)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, otherwise looks good. Thanks!
README_js.md
Outdated
@@ -353,6 +353,17 @@ import { v4 as uuidv4 } from 'uuid'; | |||
Workers](https://caniuse.com/#feat=cryptography) and we are not aware of a polyfill (let us know if | |||
you find one, please). | |||
|
|||
## Developing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't of interest to most readers. Move to PR template (preferably the hidden .github/pull_request_template.md
file).
Co-authored-by: Robert Kieffer <robert@broofa.com>
Co-authored-by: Robert Kieffer <robert@broofa.com>
Co-authored-by: Robert Kieffer <robert@broofa.com>
Co-authored-by: Robert Kieffer <robert@broofa.com>
Add a simple benchmark to be able to catch order-of-magnitude
performance regressions.