Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note that the Error display impl is public API #597

Merged
merged 1 commit into from Apr 29, 2022
Merged

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Apr 23, 2022

I just spotted diesel-rs/diesel#3143 run through, where they make some assertions based on the shape of uuid::Error's display implementation. I think it's safe to treat Display impls as public API and avoid churning them. I didn't drop any comment on the adapter types that format UUIDs themselves since I think that's pretty clear that the format is part of their contract.

@KodrAus KodrAus merged commit e0f0837 into main Apr 29, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request May 30, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://github.com/uuid-rs/uuid) | dependencies | minor | `1.0.0` -> `1.1.0` |

---

### Release Notes

<details>
<summary>uuid-rs/uuid</summary>

### [`v1.1.0`](https://github.com/uuid-rs/uuid/releases/tag/1.1.0)

[Compare Source](uuid-rs/uuid@1.0.0...1.1.0)

#### What's Changed

-   note that the Error display impl is public API by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#597
-   Fixed documentation link by [@&#8203;Razican](https://github.com/Razican) in uuid-rs/uuid#600
-   Add to_bytes_le method by [@&#8203;dfaust](https://github.com/dfaust) in uuid-rs/uuid#599
-   Prepare for 1.1.0 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#602

#### New Contributors

-   [@&#8203;Razican](https://github.com/Razican) made their first contribution in uuid-rs/uuid#600
-   [@&#8203;dfaust](https://github.com/dfaust) made their first contribution in uuid-rs/uuid#599

**Full Changelog**: uuid-rs/uuid@1.0.0...1.1.0

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1373
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
bors bot pushed a commit to stackabletech/secret-operator that referenced this pull request Jun 9, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://togithub.com/uuid-rs/uuid) | dependencies | minor | `1.0.0` -> `1.1.1` |

---

### Release Notes

<details>
<summary>uuid-rs/uuid</summary>

### [`v1.1.1`](https://togithub.com/uuid-rs/uuid/releases/tag/1.1.1)

[Compare Source](https://togithub.com/uuid-rs/uuid/compare/1.1.0...1.1.1)

#### What's Changed

-   Fix documentation typo by [@&#8203;nstinus](https://togithub.com/nstinus) in [uuid-rs/uuid#603
-   Prepare for 1.1.1 release by [@&#8203;KodrAus](https://togithub.com/KodrAus) in [uuid-rs/uuid#604

#### New Contributors

-   [@&#8203;nstinus](https://togithub.com/nstinus) made their first contribution in [uuid-rs/uuid#603

**Full Changelog**: uuid-rs/uuid@1.1.0...1.1.1

### [`v1.1.0`](https://togithub.com/uuid-rs/uuid/releases/tag/1.1.0)

[Compare Source](https://togithub.com/uuid-rs/uuid/compare/1.0.0...1.1.0)

#### What's Changed

-   note that the Error display impl is public API by [@&#8203;KodrAus](https://togithub.com/KodrAus) in [uuid-rs/uuid#597
-   Fixed documentation link by [@&#8203;Razican](https://togithub.com/Razican) in [uuid-rs/uuid#600
-   Add to_bytes_le method by [@&#8203;dfaust](https://togithub.com/dfaust) in [uuid-rs/uuid#599
-   Prepare for 1.1.0 release by [@&#8203;KodrAus](https://togithub.com/KodrAus) in [uuid-rs/uuid#602

#### New Contributors

-   [@&#8203;Razican](https://togithub.com/Razican) made their first contribution in [uuid-rs/uuid#600
-   [@&#8203;dfaust](https://togithub.com/dfaust) made their first contribution in [uuid-rs/uuid#599

**Full Changelog**: uuid-rs/uuid@1.0.0...1.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5:00 and before 6:00 every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/stackabletech/secret-operator).
kjuulh added a commit to kjuulh/octopush that referenced this pull request Nov 27, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [clap](https://github.com/clap-rs/clap) | dependencies | patch | `4.0.18` -> `4.0.27` |
| [url](https://github.com/servo/rust-url) | dependencies | minor | `^2.2` -> `^2.3` |
| [uuid](https://github.com/uuid-rs/uuid) | dependencies | minor | `^1.0` -> `^1.2` |

---

### Release Notes

<details>
<summary>clap-rs/clap</summary>

### [`v4.0.27`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4027---2022-11-24)

[Compare Source](clap-rs/clap@v4.0.26...v4.0.27)

##### Features

-   Have `Arg::value_parser` accept `Vec<impl Into<PossibleValue>>`
-   Implement `Display` and `FromStr` for `ColorChoice`

##### Fixes

-   Remove soundness issue by switching from `atty` to `is-terminal`

### [`v4.0.26`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4026---2022-11-16)

[Compare Source](clap-rs/clap@v4.0.25...v4.0.26)

##### Fixes

-   *(error)* Fix typos in `ContextKind::as_str`

### [`v4.0.25`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4025---2022-11-15)

[Compare Source](clap-rs/clap@v4.0.24...v4.0.25)

##### Features

-   *(error)* Report available subcommands when required subcommand is missing

### [`v4.0.24`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4024---2022-11-14)

[Compare Source](clap-rs/clap@v4.0.23...v4.0.24)

##### Fixes

-   Avoid panic when printing an argument that isn't built

### [`v4.0.23`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4023---2022-11-11)

[Compare Source](clap-rs/clap@v4.0.22...v4.0.23)

##### Fixes

-   Don't panic on reporting invalid-long errors when followed by invalid UTF8
-   *(help)* Clarified argument to `help` subcommand

### [`v4.0.22`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4022---2022-11-07)

[Compare Source](clap-rs/clap@v4.0.21...v4.0.22)

##### Fixes

-   *(help)* Don't overflow into next-line-help early due to stale (pre-v4) padding calculations

### [`v4.0.21`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4021---2022-11-07)

[Compare Source](clap-rs/clap@v4.0.20...v4.0.21)

##### Features

-   *(derive)* `long_about` and `long_help` attributes, without a value, force using doc comment (before it wouldn't be set if there wasn't anything different than the short help)

### [`v4.0.20`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4020---2022-11-07)

[Compare Source](clap-rs/clap@v4.0.19...v4.0.20)

##### Fixes

-   *(derive)*  Allow defaulted value parser for '()' fields

### [`v4.0.19`](https://github.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#&#8203;4019---2022-11-04)

[Compare Source](clap-rs/clap@v4.0.18...v4.0.19)

##### Features

-   `ColorChoice` now implements `ValueEnum`

</details>

<details>
<summary>servo/rust-url</summary>

### [`v2.3.1`](servo/rust-url@v2.3.0...v2.3.1)

[Compare Source](servo/rust-url@v2.3.0...v2.3.1)

### [`v2.3.0`](servo/rust-url@v2.2.2...v2.3.0)

[Compare Source](servo/rust-url@v2.2.2...v2.3.0)

### [`v2.2.2`](servo/rust-url@v2.2.1...v2.2.2)

[Compare Source](servo/rust-url@v2.2.1...v2.2.2)

### [`v2.2.1`](servo/rust-url@v2.2.0...v2.2.1)

[Compare Source](servo/rust-url@v2.2.0...v2.2.1)

</details>

<details>
<summary>uuid-rs/uuid</summary>

### [`v1.2.2`](https://github.com/uuid-rs/uuid/releases/tag/1.2.2)

[Compare Source](uuid-rs/uuid@1.2.1...1.2.2)

#### What's Changed

-   CI Cleanups by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#640
-   Remove extern crate alloc by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#645
-   Prepare for 1.2.2 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#646

**Full Changelog**: uuid-rs/uuid@1.2.1...1.2.2

### [`v1.2.1`](https://github.com/uuid-rs/uuid/releases/tag/1.2.1)

[Compare Source](uuid-rs/uuid@1.2.0...1.2.1)

#### What's Changed

-   Fix up lost re-export of v1 Timestamp by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#636
-   Prepare for 1.2.1 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#637

**Full Changelog**: uuid-rs/uuid@1.2.0...1.2.1

### [`v1.2.0`](https://github.com/uuid-rs/uuid/releases/tag/1.2.0)

[Compare Source](uuid-rs/uuid@1.1.2...1.2.0)

#### What's Changed

-   formatting changes by [@&#8203;pintariching](https://github.com/pintariching) in uuid-rs/uuid#610
-   Remove outdated Travis CI reference by [@&#8203;atouchet](https://github.com/atouchet) in uuid-rs/uuid#616
-   refactors Timestamp, Context and ClockSequence, and adds UUIDS v6, v7, v8 by [@&#8203;rrichardson](https://github.com/rrichardson) in uuid-rs/uuid#611
-   migrate from winapi to windows_sys in examples by [@&#8203;sn99](https://github.com/sn99) in uuid-rs/uuid#626
-   Update windows-sys requirement from 0.36.1 to 0.42.0 by [@&#8203;dependabot](https://github.com/dependabot) in uuid-rs/uuid#628
-   Some work on the new version features by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#625
-   Implement now in wasm by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#630
-   More work on docs by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#631
-   hide draft versions behind the unstable cfg by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#633
-   Prepare for 1.2.0 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#634

#### New Contributors

-   [@&#8203;pintariching](https://github.com/pintariching) made their first contribution in uuid-rs/uuid#610
-   [@&#8203;atouchet](https://github.com/atouchet) made their first contribution in uuid-rs/uuid#616
-   [@&#8203;sn99](https://github.com/sn99) made their first contribution in uuid-rs/uuid#626

**Full Changelog**: uuid-rs/uuid@1.1.2...1.2.0

### [`v1.1.2`](https://github.com/uuid-rs/uuid/releases/tag/1.1.2)

[Compare Source](uuid-rs/uuid@1.1.1...1.1.2)

#### What's Changed

-   Fix some doc links by [@&#8203;mbrobbel](https://github.com/mbrobbel) in uuid-rs/uuid#606
-   Prepare for 1.1.2 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#607

#### New Contributors

-   [@&#8203;mbrobbel](https://github.com/mbrobbel) made their first contribution in uuid-rs/uuid#606

**Full Changelog**: uuid-rs/uuid@1.1.1...1.1.2

### [`v1.1.1`](https://github.com/uuid-rs/uuid/releases/tag/1.1.1)

[Compare Source](uuid-rs/uuid@1.1.0...1.1.1)

#### What's Changed

-   Fix documentation typo by [@&#8203;nstinus](https://github.com/nstinus) in uuid-rs/uuid#603
-   Prepare for 1.1.1 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#604

#### New Contributors

-   [@&#8203;nstinus](https://github.com/nstinus) made their first contribution in uuid-rs/uuid#603

**Full Changelog**: uuid-rs/uuid@1.1.0...1.1.1

### [`v1.1.0`](https://github.com/uuid-rs/uuid/releases/tag/1.1.0)

[Compare Source](uuid-rs/uuid@1.0.0...1.1.0)

#### What's Changed

-   note that the Error display impl is public API by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#597
-   Fixed documentation link by [@&#8203;Razican](https://github.com/Razican) in uuid-rs/uuid#600
-   Add to_bytes_le method by [@&#8203;dfaust](https://github.com/dfaust) in uuid-rs/uuid#599
-   Prepare for 1.1.0 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#602

#### New Contributors

-   [@&#8203;Razican](https://github.com/Razican) made their first contribution in uuid-rs/uuid#600
-   [@&#8203;dfaust](https://github.com/dfaust) made their first contribution in uuid-rs/uuid#599

**Full Changelog**: uuid-rs/uuid@1.0.0...1.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yMy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMjMuMSJ9-->

Reviewed-on: https://git.front.kjuulh.io/kjuulh/octopush/pulls/39
@KodrAus KodrAus deleted the KodrAus-patch-1 branch April 11, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant