Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent inlining? #551

Closed
kinggoesgaming opened this issue Nov 1, 2021 · 4 comments
Closed

Inconsistent inlining? #551

kinggoesgaming opened this issue Nov 1, 2021 · 4 comments

Comments

@kinggoesgaming
Copy link
Member

https://github.com/uuid-rs/uuid/blob/main/src/fmt.rs#L19-L62

I have seen inconsistent inlining for the various Uuid fmt traits. I am not sure that is by design, since I did not review the changes when they were made. Just wanted to bring it up, since we are that close to 1.0 release.

@kinggoesgaming
Copy link
Member Author

Actually also exists for the adapters as well, inside the macro rules, further down the file

@KodrAus
Copy link
Member

KodrAus commented Nov 1, 2021

Ah, this is quite possibly not by design 😄

We can add these inlines at any time, but it would be great to have a look and see which ones are worthwhile.

@kinggoesgaming
Copy link
Member Author

kinggoesgaming commented Nov 6, 2021

Considering that the release is still looking a bit away (looking at you, #557), I'll benchmark inlines and no inlines tomorrow and get a PR open according

Edit: fix grammar

@KodrAus
Copy link
Member

KodrAus commented Mar 14, 2022

I think our inlines are probably pretty accurate now after all the optimization work done in the last few months. I'll go ahead and close this one, and any specific issues that come up can create fresh ones.

@KodrAus KodrAus closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants