-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent inlining? #551
Comments
Actually also exists for the adapters as well, inside the macro rules, further down the file |
Ah, this is quite possibly not by design 😄 We can add these inlines at any time, but it would be great to have a look and see which ones are worthwhile. |
Considering that the release is still looking a bit away (looking at you, #557), I'll benchmark inlines and no inlines tomorrow and get a PR open according Edit: fix grammar |
I think our inlines are probably pretty accurate now after all the optimization work done in the last few months. I'll go ahead and close this one, and any specific issues that come up can create fresh ones. |
https://github.com/uuid-rs/uuid/blob/main/src/fmt.rs#L19-L62
I have seen inconsistent inlining for the various
Uuid
fmt
traits. I am not sure that is by design, since I did not review the changes when they were made. Just wanted to bring it up, since we are that close to1.0
release.The text was updated successfully, but these errors were encountered: