New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move winapi support into a new unstable crate #537
Comments
Are these traits are to be in |
@kinggoesgaming hey! 👋 Ah these traits are specifically for a new crate, called The goal for doing this is so we don’t end up with |
It's probably just as well we're looking to move our GUID support out, because I think the unconditional bitflipping we do is actually invalid. If I call let mut guid = guiddef::GUID {
Data1: Default::default(),
Data2: Default::default(),
Data3: Default::default(),
Data4: Default::default(),
};
unsafe {
CoCreateGuid(&mut guid as *mut _);
}
let uuid = Uuid::from_guid(guid);
// This fails on `main`
assert_eq!(Some(Version::Random), uuid.get_version());
} |
For #113
Move the
winapi
support into a new unstable crate that's dedicated to UUID conversions:We can then implement this trait for
winapi
'sGuid
and for thewindows-rs
Guid
.This will move our last remaining unstable public dependency out of the
uuid
crate so it can be stabilized.The text was updated successfully, but these errors were encountered: