Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS Spacing Tokens - Resolves sass error: 'neg-4' is not a valid USWDS margin-horizontal token #4212

Merged
merged 1 commit into from Jun 14, 2021

Conversation

mahoneycm
Copy link
Contributor

Description

Resolves issue #4142 by adding the medium-negative system-tokens to _spacing-tokens.scss as well as _properties.scss.

Additional information

Input before:

@include u-margin-x("neg-4");

left unexpected output:
messageOriginal: "'neg-4' is not a valid USWDS margin-horizontal token. Valid tokens: 1px, 2px, 05, 1, 105, 2, 205, 3, neg-1px, neg-2px, neg-05, neg-1, neg-105, neg-2, neg-205, neg-3, 4, 5, 6, 7, 8, 9, 10, 15, card, card-lg, mobile, 05em, 1em, 105em, 2em, 0, auto" ╷ 57 │ @return uswds-error( │ ┌───────────^ 58 │ │ "'#{$token}' is not a valid USWDS #{$type} token.#{$valid-token-message}" 59 │ │ ); │ └───^

The error does not occur with this build..

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • [ x ] Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • [ x ] Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • [ x ] Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj added this to Development review in USWDS Sprint Board via automation Jun 3, 2021
@mejiaj mejiaj moved this from Development review to Fed final review in USWDS Sprint Board Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants