Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] [List styles] Add max width, remove bottom margin on last-child. #2906

Merged
merged 1 commit into from Feb 7, 2019

Conversation

adunkman
Copy link
Contributor

@adunkman adunkman commented Feb 7, 2019

List items should have a maximum width, similar to their <p> counterparts. Additionally, when a list is the last child of a container, it should not contain a margin-bottom (see the left border in the screenshot below).

Before After
Screenshot of list items which do not have maximum width constraints and have extra margin-bottom Screenshot of list items which are constrained by a maximum width, and do not contain extra margin-bottom

Thoughts? Was going to open an issue, but figured it’d be easier to demonstrate with a PR directly.

List items should have a maximum width, similar to their <p> counterparts for readability.

Additionally, when a list is the last child of a container, it should not contain a margin-bottom.
@thisisdano
Copy link
Member

Excellent — this was on my list of things to do! I'll review asap.

@thisisdano thisisdano merged commit a63ca60 into uswds:release-2.0 Feb 7, 2019
@thisisdano thisisdano mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants