New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS - Web components: Initial setup #5875
Draft
mejiaj
wants to merge
12
commits into
uswds-wc
Choose a base branch
from
jm-setup-stenciljs
base: uswds-wc
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
commented
Apr 25, 2024
], | ||
"scripts": { | ||
"build": "stencil build", | ||
"watch": "stencil build --watch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed --server
flag because we're using storybook instead of the local server stencil provides.
There's also some conflict with the loader
required for Storybook not updating reliably.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial setup of StencilJS to get an idea of getting started process. As well as how components could look in our environment.
This approach completely separates component work from the other code. We want to:
Closes #5874.
Setup instructions
Initial setup
web-components
directory.npm install
.npm run build
to get required loader.npm start
for storybook.Development
You'll have to run two watch scripts for now, unfortunately.
cd ./web-components/
npm run watch
.npx stencil generate usa-{{ COMPONENT_NAME }}
.npm start
for storybook.Dependency updates
New dependencies for setting up stencilJS. They're listed in the web components directories'
package.json
.