Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Documentation: Add incorrect date note to README for site Documentation page #5872

Open
1 task
Tracked by #2499
mahoneycm opened this issue Apr 16, 2024 · 0 comments · May be fixed by #5871
Open
1 task
Tracked by #2499

USWDS - Documentation: Add incorrect date note to README for site Documentation page #5872

mahoneycm opened this issue Apr 16, 2024 · 0 comments · May be fixed by #5871
Assignees
Milestone

Comments

@mahoneycm
Copy link
Contributor

mahoneycm commented Apr 16, 2024

Is your feature request related to a problem? Please describe.

NPM purposefully sets package dates to 10/26/1985 to ensure hash-identical tarballs no matter when or on what device the npm pack is ran. This can confuse users who inspect the package and see the incorrect files for the date.

Proposed Solution

Add a note to the readme, in the "Installing the design system" section to specify this is intended behavior from NPM. This will also update this section in the site Documentation

Affected pages

Documentation page →

Additional context

The site Documentation page is generated using the USWDS readme. Updating here will also add the note there after it is recompiled.

Related issue

@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Apr 16, 2024
@mahoneycm mahoneycm transferred this issue from uswds/uswds-site Apr 17, 2024
@amyleadem amyleadem removed the Status: Triage We're triaging this issue and grooming if necessary label Apr 17, 2024
@mahoneycm mahoneycm added this to the uswds 3.8.1 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Fed Final Review
Development

Successfully merging a pull request may close this issue.

2 participants