Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - Bug: Header styles are missing accordion include #5867

Open
2 tasks done
mejiaj opened this issue Apr 12, 2024 · 0 comments · May be fixed by #5903
Open
2 tasks done

USWDS - Bug: Header styles are missing accordion include #5867

mejiaj opened this issue Apr 12, 2024 · 0 comments · May be fixed by #5903
Assignees
@mejiaj
Labels
Added during Sprint Needs: Confirmation We need to confirm that this is an issue Package: Header Type: Bug A problem in the code
Milestone
uswds 3.9.0

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Apr 12, 2024

Describe the bug

Package dependencies listed in Header guidance mention usa-accordion, but its missing from dependencies.

https://github.com/uswds/uswds/blob/develop/packages/usa-header/src/styles/_index.scss

Steps to reproduce the bug

  1. Import only header package.
  2. View heading variants in storybook
  3. Confirm visual regressions from missing accordion styles

Expected Behavior

USA header package should include all required dependencies.

Related code

No response

Screenshots

No response

System setup

  • USWDS 3.8.0

Additional context

We should also confirm the following:

  • Understand performance impact of adding accordion to header (CSS output size).
  • Ensure styles aren't duplicated for users who explicitly add this missing import.
  • Ensure styles aren't duplicated when compiling with everything.

Originally reported in slack thread 🔒 - source →

Code of Conduct
@mejiaj mejiaj added Type: Bug A problem in the code Package: Header Needs: Confirmation We need to confirm that this is an issue labels Apr 12, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Apr 12, 2024
@mejiaj mejiaj self-assigned this Apr 12, 2024
@mejiaj mejiaj removed Needs: Confirmation We need to confirm that this is an issue Status: Triage We're triaging this issue and grooming if necessary labels Apr 23, 2024
@mejiaj mejiaj added this to the uswds 3.8.1 milestone Apr 23, 2024
@mejiaj mejiaj linked a pull request Apr 29, 2024 that will close this issue
Draft
@mejiaj mejiaj added the Needs: Confirmation We need to confirm that this is an issue label Apr 29, 2024
@amyleadem amyleadem modified the milestones: uswds 3.8.1, uswds 3.9.0 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejiaj mejiaj

Labels
Added during Sprint Needs: Confirmation We need to confirm that this is an issue Package: Header Type: Bug A problem in the code
Projects
USWDS Core Project Data
Status: Ready to Schedule
Milestone
uswds 3.9.0
Development

Successfully merging a pull request may close this issue.

[Test] USWDS - Header: use header forward only uswds/uswds
2 participants
@mejiaj @amyleadem