Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Identifier: Update USAGov link in Spanish variants #5892

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Apr 26, 2024

Summary

  • Updated the "Visite USA.gov en Español" link text to "Visite USAGov en Español".
  • Updated the url in the link to the Spanish usa.gov website. The link previously pointed to https://www.usa.gov/espanol/, but now points to https://www.usa.gov/es/.

Breaking change

This is a markup change. It is not a breaking change, but is important to update.

Related issue

Closes #5853

Related pull requests

Changelog PR

Preview link

Problem statement

The Spanish version of the identifier component needs to be updated to reflect the following changes:

Solution

  1. Replaced the url on Spanish versions of the component. The link previously pointed to https://www.usa.gov/espanol/, but now points to https://www.usa.gov/es/.
  2. Updated the text ""Visite USA.gov en Español" to "Visite USAGov en Español" .

Testing and review

  • Confirm the link text and url have been updated on Spanish variants of the component.
  • Confirm there are no remaining references to "Visite USA.gov en Español" or "https://www.usa.gov/espanol/".

@amyleadem amyleadem added this to the uswds 3.9.0 milestone Apr 26, 2024
@amyleadem amyleadem self-assigned this Apr 26, 2024
@amyleadem amyleadem marked this pull request as ready for review April 26, 2024 18:14
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS - Bug: Incorrect text in Spanish language versions of the identifier component
3 participants