Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons are rendering with empty "type" #5246

Closed
mejiaj opened this issue Apr 20, 2023 · 1 comment · Fixed by #5247
Closed

Buttons are rendering with empty "type" #5246

mejiaj opened this issue Apr 20, 2023 · 1 comment · Fixed by #5247
Assignees
Milestone

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Apr 20, 2023

Buttons are compiling with type="", they should be using type="button". This is affecting our documentation. For example Buttons

image

@mahoneycm
Copy link
Contributor

It looks like this is happening because the type attribute isn't being defined in the components json file. On storybook, we're defining the attribute as a control with a default value, but it doesn't get compiled with webpack.

I've created a solution on #5247 which sets the default button.json type="button". Everything seems to be working appropriately! Let me know if you see any implications of this solution that I may be missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants