Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - Enhancement: Create customizable file input text #5238

Open
amyleadem opened this issue Apr 14, 2023 · 2 comments · May be fixed by #5508
Open

USWDS - Enhancement: Create customizable file input text #5238

amyleadem opened this issue Apr 14, 2023 · 2 comments · May be fixed by #5508
Assignees
@amyleadem
Labels
Affects: Markup 🟡 Suggestion would change the markup of a component Affects: Usability Relates to the usability of our code or components Package: File Input Type: Enhancement An improvement to existing code

Comments

@amyleadem
Copy link
Contributor

amyleadem commented Apr 14, 2023 •
edited

Summary

Use data attributes to allow users to customize the language for the instructions and status text in the file input component.

Additionally, the file status text is currently broken up into pieces which can make it difficult to translate.

Notes on possible solution

Check out the following commits for a possible path forward with data attributes:

  • Add story demonstrating use of data attributes: ecacad2
  • Set text with data attributes: 10476b5
  • Update data-default-status-message to data-default-status-text : 012e01b
@amyleadem amyleadem self-assigned this Apr 14, 2023
@mejiaj mejiaj added Type: Enhancement An improvement to existing code Package: File Input labels Apr 14, 2023
@amyleadem amyleadem mentioned this issue Apr 18, 2023
Merged
@amyleadem amyleadem added the Affects: Usability Relates to the usability of our code or components label Jun 20, 2023
@amyleadem amyleadem changed the title USWDS - File input: Use data attributes for status messages USWDS - Enhancement: Use data attributes for file input status messages Jun 20, 2023
@amyleadem amyleadem added this to the uswds 3.6.0 milestone Jun 20, 2023
@amyleadem amyleadem added the Affects: Markup 🟡 Suggestion would change the markup of a component label Sep 14, 2023
@amyleadem amyleadem linked a pull request Sep 15, 2023 that will close this issue
Draft
@amyleadem
Copy link
Contributor Author

Bumping this issue to 3.8.0 to allow for time to simplify the experience of customizing component text. Possible alternatives are outlined in the related PR's comments.

@amyleadem amyleadem modified the milestones: uswds 3.7.0, uswds 3.8.0 Oct 27, 2023
@amyleadem amyleadem changed the title USWDS - Enhancement: Use data attributes for file input status messages USWDS - Enhancement: Add ability to customize file input text Dec 14, 2023
@amyleadem amyleadem changed the title USWDS - Enhancement: Add ability to customize file input text USWDS - Enhancement: Create customizable file input text Dec 14, 2023
@deebloo deebloo mentioned this issue Dec 14, 2023
Open
2 tasks
@mejiaj mejiaj removed this from the uswds 3.8.0 milestone Dec 14, 2023
@mejiaj
Copy link
Contributor

mejiaj commented Dec 14, 2023

Requires a solid strategy for multi-lingual text across components.

@brunerae brunerae mentioned this issue Dec 21, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyleadem amyleadem

Labels
Affects: Markup 🟡 Suggestion would change the markup of a component Affects: Usability Relates to the usability of our code or components Package: File Input Type: Enhancement An improvement to existing code
Projects
USWDS Core Project Data
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

USWDS - File Input: Allow custom status and instructions text uswds/uswds
2 participants
@mejiaj @amyleadem