Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - Linting: Improve formatting and linting #5225

Closed
4 tasks done
mejiaj opened this issue Apr 8, 2023 · 0 comments · Fixed by #5226
Closed
4 tasks done

USWDS - Linting: Improve formatting and linting #5225

mejiaj opened this issue Apr 8, 2023 · 0 comments · Fixed by #5226
Assignees
@mejiaj
Labels
Added during Sprint Affects: Automation Relates to process automation Affects: Build Relates to the build process Affects: CI Relates to Continuous Integration Affects: Compiling Related to compiling Sass or JavaScript Affects: Linting Relates to code linting Role: Dev Development/engineering skills needed Type: Enhancement An improvement to existing code

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Apr 8, 2023 •
edited

We should:

  • Fix SASS paths in lint.js
  • Rename lint task to lint:js
  • Add a new task for linting SASS lint:sass
  • Add new tasks formatting in CircleCI config

Path is incorrect:

uswds/tasks/lint.js

Line 7 in 62552ea

const PROJECT_SASS_SRC = "src/stylesheets";

We should point to SCSS in packages, but also ignore 3rd party styles such as uswds-elements/lib.
@mejiaj mejiaj added Type: Enhancement An improvement to existing code Affects: Compiling Related to compiling Sass or JavaScript Affects: CI Relates to Continuous Integration Affects: Automation Relates to process automation Role: Dev Development/engineering skills needed Affects: Build Relates to the build process Affects: Linting Relates to code linting Added during Sprint labels Apr 8, 2023
@mejiaj mejiaj self-assigned this Apr 8, 2023
@mejiaj mejiaj mentioned this issue Apr 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejiaj mejiaj

Labels
Added during Sprint Affects: Automation Relates to process automation Affects: Build Relates to the build process Affects: CI Relates to Continuous Integration Affects: Compiling Related to compiling Sass or JavaScript Affects: Linting Relates to code linting Role: Dev Development/engineering skills needed Type: Enhancement An improvement to existing code
Projects
USWDS Core Project Data
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

USWDS - Linting: Update lint tasks and CircleCI tests uswds/uswds
1 participant
@mejiaj