Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile radio button bug - bottom margin on last item #4180

Closed
maya opened this issue Apr 30, 2021 · 3 comments · Fixed by #4181
Closed

Tile radio button bug - bottom margin on last item #4180

maya opened this issue Apr 30, 2021 · 3 comments · Fixed by #4181
Labels
Package: Forms Type: Bug A problem in the code

Comments

@maya
Copy link
Contributor

maya commented Apr 30, 2021

Describe the bug

There's bottom margin on the last radio button of the tile variant. USWDS uses only top margins for consistency. This gives an inconsistent margin below and makes the button margin below it too large. B/c the radio buttons are inside a fieldset element margins will not collapse.

What I see

Screen Shot 2021-04-30 at 3 14 38 PM

What I expect

Screen Shot 2021-04-30 at 3 16 52 PM

@mejiaj
Copy link
Contributor

mejiaj commented May 3, 2021

Related to #4153

@maya
Copy link
Contributor Author

maya commented May 6, 2021

@mejiaj this is fixed in #4181. It's pretty straightforward. Can you review it?

@mejiaj mejiaj added this to Development review in USWDS Sprint Board May 7, 2021
@mejiaj
Copy link
Contributor

mejiaj commented May 7, 2021

Sorry, I've been focused on some other work. I've added it to our sprint board so we don't forget.

@mejiaj mejiaj moved this from Development review to Fed final review in USWDS Sprint Board May 10, 2021
USWDS Sprint Board automation moved this from Fed final review to Done May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Forms Type: Bug A problem in the code
Projects
Development

Successfully merging a pull request may close this issue.

2 participants