Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card: body-exdent variant has no scss rules #4164

Closed
btwegmann opened this issue Apr 21, 2021 · 3 comments · Fixed by #4210
Closed

Card: body-exdent variant has no scss rules #4164

btwegmann opened this issue Apr 21, 2021 · 3 comments · Fixed by #4210

Comments

@btwegmann
Copy link

Describe the bug

The .usa-card__body--exdent variant has no scss rules associated with it.

Steps to reproduce the bug

  1. Add the .usa-card__body--exdent class to a card-body element
  2. Observe no styling changes

Expected behavior

The body element should extend out over the card border, just like the other exdent variants

@mejiaj
Copy link
Contributor

mejiaj commented Apr 22, 2021

@btwegmann would you mind sharing an example use case for this? The intent behind the body was to have it contain mostly text.

I see the benefit of adding it for consistency, but I'm curious to see how it's being used.

@btwegmann
Copy link
Author

@btwegmann would you mind sharing an example use case for this? The intent behind the body was to have it contain mostly text.

I see the benefit of adding it for consistency, but I'm curious to see how it's being used.

So I don't have a specific use case in mind for this. I was actually playing around with the Card to see how the different variants (listed here: https://designsystem.digital.gov/components/card/) looked and noticed that the body-exdent one did not have any rules associated with it.

@mejiaj mejiaj added this to Bugs and ongoing work in USWDS Roadmap Backlog May 3, 2021
@mejiaj mejiaj linked a pull request Jun 15, 2021 that will close this issue
@mejiaj
Copy link
Contributor

mejiaj commented Jun 15, 2021

Closing since #4210 got merged.

@mejiaj mejiaj closed this as completed Jun 15, 2021
@mejiaj mejiaj removed this from Bugs and ongoing work in USWDS Roadmap Backlog Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants