Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New color palette is out of sync with the docs #3398

Closed
darekkay opened this issue Apr 17, 2020 · 6 comments
Closed

New color palette is out of sync with the docs #3398

darekkay opened this issue Apr 17, 2020 · 6 comments
Assignees
Labels
Type: Bug A problem in the code
Milestone

Comments

@darekkay
Copy link

darekkay commented Apr 17, 2020

This is a follow-up to the changes introduced in #3351 (based on #3329).

The colors seem to be ouf of sync with the documentation. Example:

I think the docs version are correct, because the new palette used in this repository is not fully accessible. Example:

With the values from the docs:

  • blue-20: #aacdec
  • indigo-cool-70v: #222fbf
  • Contrast ratio: 5.68 - Passes WCAG AA

I didn't check all the values, but from my automated script I only got contrast ratio issues for indigo-cool-vivid-70+ (it doesn't mean that other values are not ouf of sync).

@darekkay
Copy link
Author

@thisisdano This one is probably for you 😃

@darekkay
Copy link
Author

darekkay commented Apr 17, 2020

I've written a small script to find all differences. Here they are:

  • indigo-cool-vivid-60: #4150f2
  • indigo-cool-vivid-70: #3e4ded
  • indigo-cool-vivid-80: #222fbf
  • red-vivid-60: #b50909
  • red-vivid-70: #8b0a03

@thisisdano
Copy link
Member

Oh rats — I'll make an update. Thank you!

@thisisdano
Copy link
Member

I believe these should be the correct values:

indigo-cool-vivid-60: #3E4DED
indigo-cool-vivid-70: #222FBF
indigo-cool-vivid-80: #1B2B85
red-vivid-60: #b50909
red-vivid-70: #8b0a03

@thisisdano thisisdano added the Type: Bug A problem in the code label Apr 20, 2020
@thisisdano thisisdano added this to On-deck in USWDS Sprint Board Apr 20, 2020
@thisisdano thisisdano self-assigned this Apr 20, 2020
@nks-bix nks-bix moved this from On-deck to Sprint backlog in USWDS Sprint Board Apr 20, 2020
@thisisdano thisisdano added this to the USWDS 2.7.0 milestone May 6, 2020
@thisisdano
Copy link
Member

Working on this now and it'll be in the next release.

@thisisdano thisisdano moved this from Sprint backlog to In progress in USWDS Sprint Board May 7, 2020
@thisisdano thisisdano linked a pull request May 8, 2020 that will close this issue
@thisisdano thisisdano removed a link to a pull request May 8, 2020
@thisisdano thisisdano moved this from In progress to QA and initial review in USWDS Sprint Board May 8, 2020
@thisisdano thisisdano moved this from QA and initial review to Fed final review in USWDS Sprint Board May 8, 2020
@thisisdano
Copy link
Member

Fixed by uswds/uswds-site#948 — thanks @darekkay!

USWDS Sprint Board automation moved this from Fed final review to Done May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem in the code
Projects
Development

No branches or pull requests

2 participants