Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table cells no longer collapse #3243

Closed
thisisdano opened this issue Nov 25, 2019 · 1 comment
Closed

Table cells no longer collapse #3243

thisisdano opened this issue Nov 25, 2019 · 1 comment
Assignees
@thisisdano
Labels
Context: Sass Issue is in Sass Type: Bug A problem in the code
Projects
USWDS Sprint Board

Comments

@thisisdano
Copy link
Member

thisisdano commented Nov 25, 2019 •
edited

After updating normalize, we lost the border-collapse in our tables.

2.3.1 (incorrect)
Screen Shot 2019-11-25 at 2 53 27 PM

2.0 (correct)
Screen Shot 2019-11-25 at 2 53 46 PM

Thanks for the heads up @maya!
@thisisdano thisisdano added the Type: Bug A problem in the code label Nov 25, 2019
@thisisdano thisisdano mentioned this issue Dec 2, 2019
Merged
@thisisdano thisisdano self-assigned this Dec 3, 2019
@thisisdano thisisdano added this to the Release 2.3.2 milestone Dec 3, 2019
@thisisdano thisisdano added this to Review in USWDS Sprint Board Dec 3, 2019
@thisisdano
Copy link
Member Author

Fixed by #3250

USWDS Sprint Board automation moved this from Review to Done Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisdano thisisdano

Labels
Context: Sass Issue is in Sass Type: Bug A problem in the code
Projects
USWDS Sprint Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thisisdano