Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert success icon should be a checkmark but is identical to error icon #3230

Closed
nickscialli-usds opened this issue Nov 20, 2019 · 3 comments

Comments

@nickscialli-usds
Copy link

Description

The alert success icon is supposed to be a checkmark but is currently an exclamation point. It is identical to the icon for error alerts. See the Alert component site for the identical icons.

The icon was correct, but misaligned, as of this commit: https://github.com/uswds/uswds/blob/3eba7caf3c9abc5fb032b88a04c9c866bbb1c9dc/src/img/alerts/success.svg

But appears to have been inadvertently changed to the error icon during this commit: https://github.com/uswds/uswds/blob/9d431ceb5842e028b8a6c4ad3b996db00a70804b/src/img/alerts/success.svg

Steps to reproduce the issue

  1. View alert icons at https://designsystem.digital.gov/components/alert/

Additional information

Incorrect success icon screenshot

Issue Screenshot

@thisisdano
Copy link
Member

Ugh, yuck. Thanks for pointing that out — i'll get that fixed asap.

This was referenced Nov 20, 2019
@thisisdano
Copy link
Member

Fixed in #3233

@thisisdano thisisdano added this to Review in USWDS Sprint Board Nov 21, 2019
@thisisdano thisisdano moved this from Review to Done in USWDS Sprint Board Nov 21, 2019
@nickscialli-usds
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants