New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.3.0 #3228
Merged
Merged
Release 2.3.0 #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge 2.2.1
…ility - note: this will require that the general settings are imported before the component settings. previously, they could be imported in any order
Add components theme variables to theme/styles
Add backward compatible default to $theme-hero-image
adds US Army MEDCoE to the who is using page
Adds US Army MEDCoE to the who is using page
Use pseudoelement for collapsible footer for consistent arrow size.
Update and clarify Public Sans license
develop+3124: Update footers.
Flush old dependencies, fix vulnerabilities, integrate Prettier
[internal] Update footers
Add Public Sans v1.007
Install all USWDS in Federalist script
Update Snyk testing on Circle
Update refs to 2.3.0
Use Snyk orb and rename workflow for clarity
Run prettier on project js [and test codeclimate]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release process →
uswds-site
feature branch→USWDS 2.3.0
Properly include component theme variables: Now we're properly including the component theme variables from
_uswds-theme-components.scss
intheme/styles.scss
so anyone who uses that file in their Sass compile process (like users ofuswds-gulp
) will see component theme settings applied as expected.These should be the proper theme imports for USWDS projects:
Issue: #3117
Hero image theme setting default is now backward compatible: The
$theme-hero-image
theme variable now has a default equivalent to its effective value prev2.2.0
so users that had a working version of their hero are more likely to see no issues upgrading to the latest version of USWDS.$theme-image-path
, users can change this to any path needed. It need not refer to$theme-image-path
.uswds-theme-components
) be imported afteruswds-theme-general
. We suggest thatuswds-theme-components
be the last of the theme variables imported.Old default:
Smaller issues
:hover
selector was too broad. This attaches it to thea
link instead of the parentdiv
.grid-gap
error to assure that contact info items have space in-between.@desktop
width.Dependencies
Removes the following dependencies:
@frctl/mandelbrot
array-filter
acorn
canvas-prebuilt
chalk
cracks
jquery
Updates the following dependencies:
@types/node
→12.12.9
del
→5.1.0
@babel/preset-env
→7.7.1
@frctl/fractal
→1.2.1.beta-1
(to fix a 404-related bug)ansi-colors
→4.1.1
autoprefixer
→9.7.1
gulp-filter
→6.0.0
gulp-stylelint
→10.0.0
handlebars
→4.5.3
node-notifier
→6.0.0
node-sass
→4.13.0
normalize.css
→8.0.1
resemble.js
→3.2.3
sinon
→7.5.0
stylelint
→11.1.1
stylelint-scss
→3.12.1
Adds the following dependencies:
eslint-config-prettier
prettier
stylelint-config-prettier
stylelint-config-recommended-scss
stylelint-prettier
Other improvements
sinon
usage to use most current APInpm audit results
All but one
Low
vulnerability are related to Fractal.