Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3.0 #3228

Merged
merged 73 commits into from Nov 20, 2019
Merged

Release 2.3.0 #3228

merged 73 commits into from Nov 20, 2019

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Nov 20, 2019

Release process

  • Draft release notes
  • Update references to 2.3.0
  • Preview components in Federalist
  • Test on uswds-site feature branch

USWDS 2.3.0

Properly include component theme variables: Now we're properly including the component theme variables from _uswds-theme-components.scss in theme/styles.scss so anyone who uses that file in their Sass compile process (like users of uswds-gulp) will see component theme settings applied as expected.

These should be the proper theme imports for USWDS projects:

@import 'uswds-theme-general';
@import 'uswds-theme-typography';
@import 'uswds-theme-components'; <-- previously missing
@import 'uswds-theme-spacing';
@import 'uswds-theme-color';
@import 'uswds-theme-utilities';

Issue: #3117

Hero image theme setting default is now backward compatible: The $theme-hero-image theme variable now has a default equivalent to its effective value pre v2.2.0 so users that had a working version of their hero are more likely to see no issues upgrading to the latest version of USWDS.

  • Although the new default includes a variable reference to $theme-image-path, users can change this to any path needed. It need not refer to $theme-image-path.
  • This new default requires that the component theme variables (uswds-theme-components) be imported after uswds-theme-general. We suggest that uswds-theme-components be the last of the theme variables imported.

Old default:

$theme-hero-image: '..img/hero.png'

Smaller issues

  • Megamenu sections now appear at the proper width in the mobile menu: Fixes a megamenu column-width bug that made some subsection menu items appear at less than the full column width.
  • Contact Info underline scope applies to each item individually: This fixes an issue where the :hover selector was too broad. This attaches it to the a link instead of the parent div.
  • Contact info spaced properly in slim footer: Fixes a grid-gap error to assure that contact info items have space in-between.
  • Contact info displays properly regardless of whether utilities use important: Fixes an issue where the contact info wouldn't display properly unless project utilities were set to use important.
  • Open/close carets in the mobile big footer are now the proper size.
  • Improved footer link spacing @desktop width.
  • Updated and clarified all the font licenses.
  • Added Public Sans v1.007
  • Use Prettier formatting for files.
  • Completely install USWDS when building on Federalist.
  • Update our security test with Snyk.

Dependencies

Removes the following dependencies:

  • @frctl/mandelbrot
  • array-filter
  • acorn
  • canvas-prebuilt
  • chalk
  • cracks
  • jquery

Updates the following dependencies:

  • @types/node12.12.9
  • del5.1.0
  • @babel/preset-env7.7.1
  • @frctl/fractal1.2.1.beta-1 (to fix a 404-related bug)
  • ansi-colors4.1.1
  • autoprefixer9.7.1
  • gulp-filter6.0.0
  • gulp-stylelint10.0.0
  • handlebars4.5.3
  • node-notifier6.0.0
  • node-sass4.13.0
  • normalize.css8.0.1
  • resemble.js3.2.3
  • sinon7.5.0
  • stylelint11.1.1
  • stylelint-scss3.12.1

Adds the following dependencies:

  • eslint-config-prettier
  • prettier
  • stylelint-config-prettier
  • stylelint-config-recommended-scss
  • stylelint-prettier

Other improvements

  • Update node version to latest LTS (12.13.0) and document
  • Update sinon usage to use most current API

npm audit results

15 low, 2 moderate, 6 high, 2 critical

All but one Low vulnerability are related to Fractal.

thisisdano and others added 30 commits September 23, 2019 12:41
…ility

- note: this will require that the general settings are imported before the component settings. previously, they could be imported in any order
Add components theme variables to theme/styles
Add backward compatible default to $theme-hero-image
adds US Army MEDCoE to the who is using page
Adds US Army MEDCoE to the who is using page
Use pseudoelement for collapsible footer for consistent arrow size.
Update and clarify Public Sans license
develop+3124: Update footers.
thisisdano and others added 29 commits November 18, 2019 14:04
Flush old dependencies, fix vulnerabilities, integrate Prettier
Install all USWDS in Federalist script
Update Snyk testing on Circle
Use Snyk orb and rename workflow for clarity
Run prettier on project js [and test codeclimate]
@thisisdano thisisdano merged commit d8604d2 into master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants