Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerts with the --no-icon variant should have normal left padding #2948

Closed
thisisdano opened this issue Mar 12, 2019 · 4 comments
Closed

Alerts with the --no-icon variant should have normal left padding #2948

thisisdano opened this issue Mar 12, 2019 · 4 comments

Comments

@thisisdano
Copy link
Member

Currently, if a usa-alert has the usa-alert--no-icon variant, the icon disappears, but it leaves a big open space on the left side.

Screen Shot 2019-03-12 at 9 43 28 AM

Screen Shot 2019-03-12 at 9 42 59 AM

If an alert has usa-alert--no-icon, then it should have the same spacing between the bar on the left and the text as it has between the text and the right edge of the alert.
@maya
Copy link
Contributor

maya commented Mar 12, 2019 •
edited

If you use usa-alert without anything else, you get the proper spacing:

Screen Shot 2019-03-12 at 12 15 39 PM

@thisisdano
Copy link
Member Author

Should we update the others to match since usa-alert--no-icon does have an effect on them, just not the expected effect.

Or, should we make it so --no-icon has no effect on the named alerts?

@maya
Copy link
Contributor

maya commented Mar 12, 2019

Probably makes sense to give usa-alert--no-icon the same spacing as usa-alert.

@maya maya mentioned this issue Mar 14, 2019
Merged
@thisisdano
Copy link
Member Author

Fixed in #2959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maya @thisisdano