Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 6 - System Fonts #2944

Closed
stphnwlkr opened this issue Mar 11, 2019 · 6 comments
Closed

Beta 6 - System Fonts #2944

stphnwlkr opened this issue Mar 11, 2019 · 6 comments
Assignees
Labels
Type: Bug A problem in the code

Comments

@stphnwlkr
Copy link

A beta 6 anomaly - If you use just system fonts a stray comma is placed at the front and causes the system fonts not to work

[class*='font-sans-'] {
font-family: , -apple-system, BlinkMacSystemFont, Segoe UI, Roboto, Helvetica, Arial, sans-serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol !important;
}

@stphnwlkr
Copy link
Author

Turns out there is more to this than just the comma... doing some more research.

@thisisdano
Copy link
Member

Aw crap — I think I know what this is...
I'm sure I can fix the comma, but does it still fail if the comma goes away?

@stphnwlkr
Copy link
Author

Yes it is still a problem...see https://stphnwlkr.dev/

@thisisdano
Copy link
Member

Hm. OK. This issue is next on my list.

@thisisdano thisisdano self-assigned this Mar 11, 2019
@thisisdano thisisdano added Type: Bug A problem in the code 2.0 labels Mar 11, 2019
@stphnwlkr
Copy link
Author

It is the comma...there were 47 instances and I missed a couple of key ones

@maya
Copy link
Contributor

maya commented Mar 12, 2019

Fixed in #2947. @stphnwlkr let us know if there are any other issues!

@maya maya closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem in the code
Projects
None yet
Development

No branches or pull requests

3 participants