Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change button background to background-color #2930

Merged
merged 1 commit into from Mar 11, 2019
Merged

Change button background to background-color #2930

merged 1 commit into from Mar 11, 2019

Conversation

maya
Copy link
Contributor

@maya maya commented Mar 8, 2019 •
edited

Changes button background to background-color to match the other CSS properties for outline buttons. Otherwise, you cannot add background images or other background properties to the button, since background is a "catch-all."

@maya maya requested a review from a team March 8, 2019 22:21
thisisdano
thisisdano approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch — thanks!

@thisisdano thisisdano merged commit 630855c into release-2.0 Mar 11, 2019
@thisisdano thisisdano deleted the update-button-background branch March 11, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maya @thisisdano