Use all for media queries instead of screen only
#2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saracope
reviewed
Feb 15, 2019
|
Cool. It looks like the reverse text might print a little light, but it's probably an improvement from what it was doing before. |
|
Good to remember that we shouldn't put any critical images in backgrounds since they won't print! |
|
@saracope please hold on merging until we sort out some Federalist issues |
saracope
approved these changes
Feb 15, 2019
This was referenced Feb 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
This PR changes the scope of media queries to all media types instead of screen only. This allows media query styling to apply to print jobs, fixing a number of current issues with print performance. In testing, printing to standard 8.5 x 11" paper results in mobile-style output, which is perfect.
We haven't uncovered any potential problems with this new scope, but it's worth a bit more research time to make sure there aren't any unintended consequences, especially accessibility issues.
Q: are there some places where reverse text will be an issue?
Fixes #2907
Fixes #2883
With
Print background graphicschecked: